Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable staticcheck linter. Disable check for folder /pkg and /test by… #5788

Merged
merged 1 commit into from Feb 9, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jan 20, 2023

… now.

Signed-off-by: Xun Jiang blackpiglet@gmail.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5734

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Jan 20, 2023
@blackpiglet blackpiglet force-pushed the enable_staticcheck branch 2 times, most recently from cb5bb42 to ad292ba Compare January 20, 2023 02:12
@blackpiglet blackpiglet force-pushed the enable_staticcheck branch 6 times, most recently from c64a952 to 97422db Compare January 20, 2023 02:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #5788 (955eec7) into main (71b459d) will decrease coverage by 0.15%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #5788      +/-   ##
==========================================
- Coverage   40.76%   40.61%   -0.15%     
==========================================
  Files         244      244              
  Lines       21172    21252      +80     
==========================================
+ Hits         8631     8632       +1     
- Misses      11917    11996      +79     
  Partials      624      624              
Impacted Files Coverage Δ
internal/hook/wait_exec_hook_handler.go 71.77% <25.00%> (ø)
internal/storage/storagelocation.go 78.78% <100.00%> (-1.77%) ⬇️
pkg/persistence/object_store.go 53.09% <0.00%> (-3.10%) ⬇️
pkg/podvolume/restorer.go 9.09% <0.00%> (-2.48%) ⬇️
pkg/util/kube/pod.go 0.00% <0.00%> (ø)
pkg/podvolume/restorer_factory.go 0.00% <0.00%> (ø)
pkg/persistence/object_store_layout.go 92.30% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet force-pushed the enable_staticcheck branch 2 times, most recently from c805633 to 395c1a1 Compare January 20, 2023 03:08
… now.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@sseago sseago merged commit 0be05c9 into vmware-tanzu:main Feb 9, 2023
@blackpiglet blackpiglet deleted the enable_staticcheck branch March 10, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve staticcheck linter reported issues
4 participants