Add option "--service-account-name" to install cmd #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option "--service-account-name" is to be added to that user can use an existing service account for velero and node-agent pods. This is helpful for users who wanna use IRSA. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
install-sa-option
branch
from
c36f85b
to
dbff64d
Compare
Codecov Report
@@ Coverage Diff @@
## main #5802 +/- ##
==========================================
- Coverage 40.76% 40.60% -0.17%
==========================================
Files 244 244
Lines 21172 21264 +92
==========================================
+ Hits 8631 8634 +3
- Misses 11917 12006 +89
Partials 624 624
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qiuming-best
approved these changes
Jan 31, 2023
ywk253100
approved these changes
Feb 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option "--service-account-name" is to be added to that user can use an existing service account for velero and node-agent pods. This is helpful for users who wanna use IRSA.
Signed-off-by: Daniel Jiang jiangd@vmware.com
Thank you for contributing to Velero!
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.