Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated PVB/PVR for patching Failed Phase during startup #5828

Merged

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Feb 3, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Use pvb/pvr with updated failed phase for patching during startup

Does your change fix a particular issue?

Fixes #5827

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai changed the title Use pvb/pvr with updated failed phase for patching during startup Fail pvb/pvr when InProgress during startup Feb 3, 2023
@kaovilai kaovilai changed the title Fail pvb/pvr when InProgress during startup Use updated PVB/PVR for patching Failed Phase during startup Feb 3, 2023
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup branch from c02f353 to 914c02a Compare February 3, 2023 18:38
@kaovilai kaovilai marked this pull request as ready for review February 3, 2023 18:39
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup branch from 914c02a to 38eb4a9 Compare February 3, 2023 19:07
Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@sseago sseago merged commit 19b8556 into vmware-tanzu:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InProgress PodVolumeBackup/PodVolumeRestore are not marked as failed when node-agent restarts
4 participants