Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore finalizer and managedFields #5853

Merged
merged 1 commit into from Feb 20, 2023

Conversation

ywk253100
Copy link
Contributor

Restore finalizer and managedFields of metadata during the restoration

Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Restore finalizer and managedFields of metadata during the restoration

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #5853 (bcad9ae) into main (8f76907) will decrease coverage by 0.03%.
The diff coverage is 52.54%.

@@            Coverage Diff             @@
##             main    #5853      +/-   ##
==========================================
- Coverage   40.91%   40.89%   -0.03%     
==========================================
  Files         248      248              
  Lines       21528    21589      +61     
==========================================
+ Hits         8809     8828      +19     
- Misses      12082    12117      +35     
- Partials      637      644       +7     
Impacted Files Coverage Δ
pkg/builder/object_meta.go 0.00% <0.00%> (ø)
pkg/restore/restore.go 64.63% <25.00%> (-0.50%) ⬇️
pkg/restore/service_action.go 60.36% <69.23%> (-0.62%) ⬇️
pkg/controller/pod_volume_backup_controller.go 38.74% <0.00%> (-1.48%) ⬇️
pkg/controller/pod_volume_restore_controller.go 25.00% <0.00%> (-0.95%) ⬇️
pkg/cmd/cli/nodeagent/server.go 12.72% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kaovilai
Copy link
Contributor

kaovilai commented Feb 13, 2023

Fyi we hit some issue from Red Hat QE during release-1.9 fork testing here
https://issues.redhat.com/browse/OADP-1289
prior to reverting PR https://github.com/vmware-tanzu/velero/pull/5846/files getting merged.

What made you revert the original release-1.9 PR #5808?

@ywk253100
Copy link
Contributor Author

@kaovilai There are some issues with restoring the service account token secrets which cause Secrets \"deployer-token-rrjqx\" not found errors during restoring the managdFields.
The PR #5843 is needed to fix the secret issues before supporting the restoration of managedFields, but we will not backport it into the 1.9 branch anymore, we only support it in 1.10+

@ywk253100 ywk253100 added this to the v1.11 milestone Feb 17, 2023
@ywk253100
Copy link
Contributor Author

Fixes #5580 #5701 #2416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants