Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore storageclasses before persistentvolumes and persistentvolumeclaims #594

Closed
ncdc opened this issue Jun 25, 2018 · 2 comments · Fixed by #971
Closed

Restore storageclasses before persistentvolumes and persistentvolumeclaims #594

ncdc opened this issue Jun 25, 2018 · 2 comments · Fixed by #971
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start!
Milestone
v1.0.0

Comments

@ncdc
Copy link
Contributor

ncdc commented Jun 25, 2018

This is necessary so the PVs and PVCs can be created correctly.
@ncdc ncdc added P1 - Important Enhancement/User End-User Enhancement to Velero labels Jun 25, 2018
@ncdc ncdc added this to the v1.0.0 milestone Jun 25, 2018
@skriss skriss added the Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! label Jul 17, 2018
@shubheksha
Copy link
Contributor

I'd like to pick this up! @ncdc, can I get some more info to get started on it?

@ncdc
Copy link
Contributor Author

ncdc commented Oct 11, 2018

@shubheksha sure! We have default restore priorities here: https://github.com/heptio/ark/blob/d7dfffa37358584d66e2d433cd79c7b8f2f43f4e/pkg/cmd/server/server.go#L456-L475. Need to insert storageclasses in the right place and test it.

@shubheksha shubheksha mentioned this issue Oct 21, 2018
Merged
@wwitzel3 wwitzel3 mentioned this issue Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start!
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Restore storageclasses before pvs and pvcs shubheksha/ark
3 participants
@ncdc @skriss @shubheksha