Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5935 #5956

Merged
merged 1 commit into from Mar 9, 2023
Merged

Fix issue 5935 #5956

merged 1 commit into from Mar 9, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Mar 6, 2023

Fix issue #5935, refactor the logics for backup/restore persistent log, so as to remove the contest to gzip writer

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #5956 (30e4a02) into main (94fec66) will decrease coverage by 0.10%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
- Coverage   39.94%   39.84%   -0.10%     
==========================================
  Files         254      255       +1     
  Lines       22361    22379      +18     
==========================================
- Hits         8932     8918      -14     
- Misses      12773    12808      +35     
+ Partials      656      653       -3     
Impacted Files Coverage Δ
pkg/util/logging/persist_logger.go 0.00% <0.00%> (ø)
pkg/controller/backup_controller.go 55.58% <25.00%> (-0.30%) ⬇️
pkg/controller/restore_controller.go 67.70% <58.82%> (+0.13%) ⬆️
pkg/restore/restore.go 64.73% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the issue-fix-5935 branch 2 times, most recently from d2f927b to dfed82f Compare March 6, 2023 15:10
blackpiglet
blackpiglet previously approved these changes Mar 8, 2023
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor!

pkg/util/logging/persist_logger.go Outdated Show resolved Hide resolved
pkg/util/logging/persist_logger.go Outdated Show resolved Hide resolved
pkg/util/logging/persist_logger.go Outdated Show resolved Hide resolved
pkg/util/logging/persist_logger.go Outdated Show resolved Hide resolved
pkg/util/logging/persist_logger.go Outdated Show resolved Hide resolved
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-5935 branch 3 times, most recently from 4be46c8 to c521ff0 Compare March 9, 2023 05:32
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blackpiglet blackpiglet merged commit 6d8f086 into vmware-tanzu:main Mar 9, 2023
@Lyndon-Li Lyndon-Li deleted the issue-fix-5935 branch March 9, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants