Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linter revive and resolve found errors: part2 #6177

Merged
merged 1 commit into from Apr 26, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Apr 24, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet changed the title Linter revive part2 Enable linter revive and resolve found errors: part2 Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #6177 (bb31de3) into main (a0b0b7c) will decrease coverage by 0.03%.
The diff coverage is 54.34%.

@@            Coverage Diff             @@
##             main    #6177      +/-   ##
==========================================
- Coverage   41.29%   41.27%   -0.03%     
==========================================
  Files         251      251              
  Lines       23386    23377       -9     
==========================================
- Hits         9658     9648      -10     
- Misses      12970    12974       +4     
+ Partials      758      755       -3     
Impacted Files Coverage Δ
pkg/plugin/clientmgmt/process/registry.go 26.27% <ø> (ø)
pkg/repository/config/gcp.go 58.33% <0.00%> (+4.48%) ⬆️
pkg/repository/udmrepo/kopialib/lib_repo.go 30.31% <0.00%> (+0.17%) ⬆️
pkg/repository/udmrepo/kopialib/repo_init.go 86.41% <ø> (ø)
pkg/uploader/kopia/shim.go 0.00% <0.00%> (ø)
pkg/uploader/provider/provider.go 0.00% <0.00%> (ø)
pkg/repository/backup_repo_op.go 63.63% <50.00%> (ø)
pkg/restore/restore.go 64.74% <72.72%> (ø)
...kupitemaction/v1/restartable_backup_item_action.go 82.50% <100.00%> (ø)
...kupitemaction/v2/restartable_backup_item_action.go 61.64% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review April 24, 2023 09:26
Lyndon-Li
Lyndon-Li previously approved these changes Apr 25, 2023
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Copy link
Contributor

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ywk253100 ywk253100 merged commit e106bbf into vmware-tanzu:main Apr 26, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants