Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable staticcheck and resolve found issues. #6183

Merged
merged 2 commits into from Apr 25, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Apr 25, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests labels Apr 25, 2023
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #6183 (fe18685) into main (1fd28e8) will decrease coverage by 0.01%.
The diff coverage is 15.38%.

❗ Current head fe18685 differs from pull request most recent head cb0ada1. Consider uploading reports for the commit cb0ada1 to get more accurate results

@@            Coverage Diff             @@
##             main    #6183      +/-   ##
==========================================
- Coverage   41.31%   41.30%   -0.01%     
==========================================
  Files         251      251              
  Lines       23379    23383       +4     
==========================================
  Hits         9658     9658              
- Misses      12963    12967       +4     
  Partials      758      758              
Impacted Files Coverage Δ
pkg/backup/item_collector.go 56.26% <0.00%> (-0.48%) ⬇️
pkg/cmd/cli/select_option.go 61.90% <0.00%> (ø)
pkg/cmd/server/server.go 5.16% <0.00%> (-0.03%) ⬇️
pkg/cmd/util/output/output.go 0.00% <ø> (ø)
pkg/plugin/framework/common/server_errors.go 0.00% <ø> (ø)
pkg/podvolume/backupper.go 4.26% <0.00%> (ø)
pkg/backup/backup.go 52.25% <50.00%> (+<0.01%) ⬆️
pkg/controller/restore_operations_controller.go 47.25% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Lyndon-Li
Lyndon-Li previously approved these changes Apr 25, 2023
qiuming-best
qiuming-best previously approved these changes Apr 25, 2023
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
@blackpiglet blackpiglet dismissed stale reviews from qiuming-best and Lyndon-Li via 51c6708 April 25, 2023 07:49
@blackpiglet blackpiglet merged commit a0b0b7c into vmware-tanzu:main Apr 25, 2023
22 checks passed
@blackpiglet blackpiglet mentioned this pull request Apr 25, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants