Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable errcheck linter and resolve found issues. #6208

Merged
merged 1 commit into from May 5, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Apr 28, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #6208 (f051eca) into main (fbba4e5) will decrease coverage by 0.10%.
The diff coverage is 2.12%.

@@            Coverage Diff             @@
##             main    #6208      +/-   ##
==========================================
- Coverage   41.32%   41.22%   -0.10%     
==========================================
  Files         252      252              
  Lines       23371    23418      +47     
==========================================
- Hits         9658     9655       -3     
- Misses      12961    13008      +47     
- Partials      752      755       +3     
Impacted Files Coverage Δ
pkg/backup/backup.go 51.93% <0.00%> (-0.32%) ⬇️
pkg/client/factory.go 20.93% <0.00%> (-2.15%) ⬇️
pkg/cmd/cli/nodeagent/server.go 11.91% <0.00%> (-0.42%) ⬇️
pkg/cmd/server/server.go 5.11% <0.00%> (-0.06%) ⬇️
pkg/cmd/util/output/output.go 0.00% <0.00%> (ø)
pkg/controller/backup_controller.go 56.32% <0.00%> (-0.06%) ⬇️
pkg/controller/backup_repository_controller.go 63.83% <0.00%> (-0.29%) ⬇️
pkg/controller/backup_sync_controller.go 45.00% <0.00%> (-0.98%) ⬇️
pkg/controller/restore_controller.go 64.83% <0.00%> (-0.24%) ⬇️
pkg/install/resources.go 49.57% <0.00%> (-2.64%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

@blackpiglet blackpiglet mentioned this pull request Apr 28, 2023
33 tasks
@blackpiglet blackpiglet marked this pull request as ready for review May 5, 2023 03:01
@qiuming-best qiuming-best merged commit 4db1a78 into vmware-tanzu:main May 5, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants