Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics when backup failed with validation error #6318

Merged
merged 1 commit into from Jun 9, 2023

Conversation

ywk253100
Copy link
Contributor

Update metrics when backup failed with validation error

Fixes #6265

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Update metrics when backup failed with validation error

Fixes vmware-tanzu#6265

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #6318 (25cc8c2) into main (f9057bd) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6318      +/-   ##
==========================================
- Coverage   40.97%   40.96%   -0.02%     
==========================================
  Files         255      255              
  Lines       23830    23834       +4     
==========================================
- Hits         9764     9763       -1     
- Misses      13304    13309       +5     
  Partials      762      762              
Impacted Files Coverage Δ
pkg/controller/backup_controller.go 56.54% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

@ywk253100 ywk253100 requested a review from allenxu404 May 31, 2023 00:41
@allenxu404
Copy link
Contributor

LGTM

@ywk253100 ywk253100 merged commit 89c10dd into vmware-tanzu:main Jun 9, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics for Scheduled Backups
5 participants