Remove Wait VolumeSnapshot to ReadyToUse logic. #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Dependencies
sseago
previously approved these changes
Jun 1, 2023
Lyndon-Li
reviewed
Jun 2, 2023
Due to the logic moving to plugin, and the plugin cannot read the Velero server's resourceTimeout setting, add the resourceTimeout in the backup annotation to pass to plugin. Remove VolumeSnapshotContent reset code from Velero server. Signed-off-by: Xun Jiang <jxun@vmware.com>
Lyndon-Li
approved these changes
Jun 5, 2023
shubham-pampattiwar
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the logic moving to plugin, and the plugin cannot read the Velero server's resourceTimeout setting, add the resourceTimeout in the backup annotation to pass to plugin.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6099
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.