Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for pkg/uploader #6374

Merged
merged 2 commits into from Jun 13, 2023
Merged

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Jun 8, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
#6256

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@qiuming-best qiuming-best added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 8, 2023
@qiuming-best qiuming-best force-pushed the uploader-UT branch 2 times, most recently from c54b2c5 to 2441cba Compare June 9, 2023 04:06
@qiuming-best qiuming-best removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 9, 2023
@qiuming-best qiuming-best force-pushed the uploader-UT branch 4 times, most recently from caa5c6e to ad7173d Compare June 13, 2023 07:20
Signed-off-by: Ming <mqiu@vmware.com>
@qiuming-best qiuming-best force-pushed the uploader-UT branch 3 times, most recently from 351f531 to 1d7eb05 Compare June 13, 2023 07:56
@qiuming-best qiuming-best changed the title [WIP] Add unit test for pkg/uploader Add unit test for pkg/uploader Jun 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6374 (f74054f) into main (8cd55d1) will increase coverage by 1.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6374      +/-   ##
==========================================
+ Coverage   48.32%   49.88%   +1.56%     
==========================================
  Files         227      227              
  Lines       23376    23376              
==========================================
+ Hits        11296    11661     +365     
+ Misses      11214    10836     -378     
- Partials      866      879      +13     
Impacted Files Coverage Δ
pkg/uploader/kopia/snapshot.go 79.71% <100.00%> (+47.64%) ⬆️
pkg/uploader/provider/kopia.go 85.03% <100.00%> (+30.61%) ⬆️
pkg/uploader/provider/restic.go 79.41% <100.00%> (+54.90%) ⬆️

... and 3 files with indirect coverage changes

@ywk253100 ywk253100 merged commit 78025a0 into vmware-tanzu:main Jun 13, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants