Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the deletion frequency for gc controller #6414

Merged
merged 1 commit into from Jun 26, 2023

Conversation

allenxu404
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Clarify there is the deletion frequency for gc controller so the effects of expiration are not applied immediately.

Does your change fix a particular issue?

Fixes #6245

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: allenxu404 <qix2@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #6414 (3bd423e) into main (ef443fe) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 3bd423e differs from pull request most recent head c1ca9a0. Consider uploading reports for the commit c1ca9a0 to get more accurate results

@@            Coverage Diff             @@
##             main    #6414      +/-   ##
==========================================
+ Coverage   53.77%   53.81%   +0.03%     
==========================================
  Files         228      228              
  Lines       23777    23777              
==========================================
+ Hits        12787    12795       +8     
+ Misses      10043    10036       -7     
+ Partials      947      946       -1     

see 1 file with indirect coverage changes

@blackpiglet blackpiglet merged commit 9417f25 into vmware-tanzu:main Jun 26, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Inconsistent deletion time when using TTL
4 participants