Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the expired deletebackuprequests that are stuck in "InProgress" #6476

Merged
merged 1 commit into from Jul 26, 2023

Conversation

reasonerjt
Copy link
Contributor

@reasonerjt reasonerjt commented Jul 10, 2023

state

This PR should fix #6042
But I couldn't reproduce the problem to make the dbr stuck in InProgress status, still waiting for the author to clarify.

More details please refer to the discussion under #6042

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

state

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #6476 (c500e8d) into main (e54a8af) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #6476      +/-   ##
==========================================
- Coverage   60.18%   60.15%   -0.04%     
==========================================
  Files         229      229              
  Lines       24215    24220       +5     
==========================================
- Hits        14575    14570       -5     
- Misses       8632     8641       +9     
- Partials     1008     1009       +1     
Impacted Files Coverage Δ
pkg/controller/backup_deletion_controller.go 57.39% <75.00%> (+0.12%) ⬆️

... and 5 files with indirect coverage changes

@reasonerjt reasonerjt changed the title [WIP] Delete the expired deletebackuprequests that are stuck in "InProgress" Delete the expired deletebackuprequests that are stuck in "InProgress" Jul 21, 2023
@blackpiglet blackpiglet merged commit 6997e4a into vmware-tanzu:main Jul 26, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsuccessful deletebackuprequests should timeout
4 participants