Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PVC's selector in backup's PVC action. #6481

Merged
merged 1 commit into from Jul 27, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 11, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6444

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

Codecov Report

Merging #6481 (732d3ff) into main (49e8058) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 732d3ff differs from pull request most recent head 1a6ef0f. Consider uploading reports for the commit 1a6ef0f to get more accurate results

@@           Coverage Diff           @@
##             main    #6481   +/-   ##
=======================================
  Coverage   60.03%   60.04%           
=======================================
  Files         229      229           
  Lines       24491    24489    -2     
=======================================
  Hits        14704    14704           
+ Misses       8774     8772    -2     
  Partials     1013     1013           
Impacted Files Coverage Δ
pkg/backup/backup_pv_action.go 45.71% <0.00%> (+2.47%) ⬆️

@blackpiglet blackpiglet marked this pull request as ready for review July 11, 2023 06:24
Lyndon-Li
Lyndon-Li previously approved these changes Jul 11, 2023
@reasonerjt
Copy link
Contributor

Can we make sure the removal of labelSelector only happens when the restore will be done via dynamic provision? (podvolume, CSI).

Lyndon-Li
Lyndon-Li previously approved these changes Jul 26, 2023
pkg/backup/backup_pv_action.go Outdated Show resolved Hide resolved
pkg/backup/backup_pv_action.go Outdated Show resolved Hide resolved
reasonerjt
reasonerjt previously approved these changes Jul 27, 2023
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR to unblock merging it, I'm fine the cosmetic code change be applied afterwards

Lyndon-Li
Lyndon-Li previously approved these changes Jul 27, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
@Lyndon-Li Lyndon-Li merged commit a6d79fc into vmware-tanzu:main Jul 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI plugin cannot work with PVC using selector to filter PV
4 participants