Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kopia logging from util/logging to remove indirect dependency in velero plugins #6484

Merged
merged 1 commit into from Jul 13, 2023

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Jul 11, 2023

when running go mod why -m github.com/kopia/kopia in velero-plugins prior to this change you will see following

❯ go mod why -m github.com/kopia/kopia
github.com/konveyor/openshift-velero-plugin/velero-plugins
github.com/vmware-tanzu/velero/pkg/plugin/framework
github.com/vmware-tanzu/velero/pkg/util/logging
github.com/kopia/kopia/repo/logging

after

❯ go mod why -m github.com/kopia/kopia
(main module does not need module github.com/kopia/kopia)

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Velero Plugins no longer need kopia indirect dependency in their go.mod

Motivation for change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #6484 (78929af) into main (49e8058) will not change coverage.
The diff coverage is n/a.

❗ Current head 78929af differs from pull request most recent head 6809745. Consider uploading reports for the commit 6809745 to get more accurate results

@@           Coverage Diff           @@
##             main    #6484   +/-   ##
=======================================
  Coverage   60.03%   60.03%           
=======================================
  Files         229      229           
  Lines       24491    24491           
=======================================
  Hits        14704    14704           
  Misses       8774     8774           
  Partials     1013     1013           
Impacted Files Coverage Δ
pkg/repository/udmrepo/kopialib/lib_repo.go 77.46% <ø> (ø)
...g/repository/udmrepo/kopialib/logging/kopia_log.go 75.53% <ø> (ø)
pkg/uploader/kopia/snapshot.go 79.71% <ø> (ø)

@kaovilai kaovilai changed the title Moving kopia logging to remove kopia from indirect dependency in velero plugins Moving kopia logging from util/logging to remove kopia from indirect dependency in velero plugins Jul 12, 2023
…ro plugins

when running `go mod why -m github.com/kopia/kopia` in velero-plugins prior to this change you will see following

```
❯ go mod why -m github.com/kopia/kopia
github.com/konveyor/openshift-velero-plugin/velero-plugins
github.com/vmware-tanzu/velero/pkg/plugin/framework
github.com/vmware-tanzu/velero/pkg/util/logging
github.com/kopia/kopia/repo/logging
```

after
```
❯ go mod why -m github.com/kopia/kopia
(main module does not need module github.com/kopia/kopia)
```

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title Moving kopia logging from util/logging to remove kopia from indirect dependency in velero plugins Move kopia logging from util/logging to remove indirect dependency in velero plugins Jul 12, 2023
@kaovilai kaovilai requested a review from Lyndon-Li July 12, 2023 15:32
@kaovilai
Copy link
Contributor Author

seeing if I can restart linter check via reopening

@kaovilai kaovilai closed this Jul 12, 2023
@kaovilai kaovilai reopened this Jul 12, 2023
@shubham-pampattiwar
Copy link
Collaborator

@Lyndon-Li Please take another look, Thanks !

@Lyndon-Li Lyndon-Li merged commit 17d782f into vmware-tanzu:main Jul 13, 2023
44 of 45 checks passed
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 18, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 18, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jul 20, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants