Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 6490 #6491

Merged
merged 1 commit into from Jul 14, 2023
Merged

Fix issue 6490 #6491

merged 1 commit into from Jul 14, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Jul 13, 2023

Fix issue 6490, If a backup/restore has multiple async operations and one operation fails while others are still in-progress, when all the operations finish, the backup/restore will be set as Completed falsely

Fix #6490

@codecov-commenter
Copy link

Codecov Report

Merging #6491 (2618359) into main (17d782f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2618359 differs from pull request most recent head 79b1d71. Consider uploading reports for the commit 79b1d71 to get more accurate results

@@           Coverage Diff           @@
##             main    #6491   +/-   ##
=======================================
  Coverage   60.03%   60.03%           
=======================================
  Files         229      229           
  Lines       24491    24491           
=======================================
  Hits        14704    14704           
  Misses       8774     8774           
  Partials     1013     1013           
Impacted Files Coverage Δ
pkg/controller/backup_operations_controller.go 46.09% <100.00%> (ø)

@Lyndon-Li Lyndon-Li marked this pull request as ready for review July 13, 2023 09:37
@Lyndon-Li Lyndon-Li requested a review from sseago July 13, 2023 09:37
@Lyndon-Li
Copy link
Contributor Author

@sseago Please help to review this Async Operation change.

sseago
sseago previously approved these changes Jul 13, 2023
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li
Copy link
Contributor Author

Added the same changes for restore.

@Lyndon-Li Lyndon-Li requested a review from sseago July 14, 2023 07:42
@sseago sseago merged commit b5bd55f into vmware-tanzu:main Jul 14, 2023
22 checks passed
blackpiglet pushed a commit to blackpiglet/velero that referenced this pull request Jul 15, 2023
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async operation sets backup/restore to Completed status falsely
4 participants