Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the skipped PV and print the summary in backup log #6496

Merged
merged 1 commit into from Jul 20, 2023

Conversation

reasonerjt
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added has-unit-tests Website non-docs changes for the website labels Jul 14, 2023
@github-actions github-actions bot removed the Website non-docs changes for the website label Jul 14, 2023
@reasonerjt reasonerjt force-pushed the track-skipped-pvc branch 9 times, most recently from caa2c92 to 324642d Compare July 14, 2023 18:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #6496 (315eefd) into main (e54a8af) will decrease coverage by 0.29%.
The diff coverage is 79.72%.

@@            Coverage Diff             @@
##             main    #6496      +/-   ##
==========================================
- Coverage   60.18%   59.90%   -0.29%     
==========================================
  Files         229      237       +8     
  Lines       24215    25252    +1037     
==========================================
+ Hits        14575    15127     +552     
- Misses       8632     9076     +444     
- Partials     1008     1049      +41     
Impacted Files Coverage Δ
pkg/backup/request.go 100.00% <ø> (ø)
pkg/backup/backup.go 51.87% <22.22%> (-0.01%) ⬇️
pkg/backup/item_backupper.go 70.20% <47.82%> (-3.55%) ⬇️
pkg/podvolume/backupper.go 86.93% <97.95%> (+1.35%) ⬆️
pkg/backup/pv_skip_tracker.go 100.00% <100.00%> (ø)
pkg/backup/pvc_snapshot_tracker.go 88.67% <100.00%> (+3.31%) ⬆️
pkg/controller/backup_controller.go 61.25% <100.00%> (+0.06%) ⬆️
pkg/controller/backup_finalizer_controller.go 57.93% <100.00%> (+0.33%) ⬆️
pkg/podvolume/util.go 88.40% <100.00%> (+0.34%) ⬆️

... and 29 files with indirect coverage changes

@reasonerjt reasonerjt force-pushed the track-skipped-pvc branch 6 times, most recently from 315eefd to 0a069b5 Compare July 18, 2023 15:37
@reasonerjt reasonerjt changed the title [WIP]Track the skipped PVC and print the summary in backup log Track the skipped PV and print the summary in backup log Jul 19, 2023
Partially address the requirements in vmware-tanzu#5834

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@ywk253100 ywk253100 merged commit 2548b20 into vmware-tanzu:main Jul 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants