GetS3Credentials pass profile from config to NewSharedCredentials #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Lyndon-Li
added
target/1.10.4
target/1.11.2
and removed
target/1.10.4
target/1.11.2
labels
Lyndon-Li
approved these changes
Jul 31, 2023
|
@kaovilai Thanks for the fix! Would you also cherry-pick this PR to 1.10 and 1.11 branch? |
|
Yup. Will do sometimes during the work day Monday. |
|
release-1.10 cp |
|
release-1.11 cp |
qiuming-best
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Non default s3 credential profiles work on Unified Repository Provider (kopia)
GetS3Credentials pass profile from config to NewSharedCredentials
Does your change fix a particular issue?
Fixes #6557
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.