Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async item operations always fail on read-only BSL #6753

Closed
Lyndon-Li opened this issue Sep 4, 2023 · 1 comment
Closed

Async item operations always fail on read-only BSL #6753

Lyndon-Li opened this issue Sep 4, 2023 · 1 comment
Assignees
Labels
Area/CSI Related to Container Storage Interface support area/datamover target/1.11.2 target/1.12-rc.2
Milestone

Comments

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Sep 4, 2023

If a BSL is set to readOnly for its accessMode, the restore will be marked as ParitiallyFailed and all the async operations are left orphaned.
For example, if the BSL is readOnly, the data mover restore will be set as ParitiallyFailed quickly and the DataDownloads continue and finally complete.

It is definitely a valid use case to set the BSL readOnly while doing a restore, however, at present, Velero restore cannot follow the read-only BSL rule as it needs to write the restore metadata to the backup store.
At present, we cannot solve this contradiction, so Velero restore doesn't do the BSL readOnly check but ignore it.
The async operation should follow the same behavior until the conflict is fixed.

@Lyndon-Li Lyndon-Li added Area/CSI Related to Container Storage Interface support area/datamover labels Sep 4, 2023
@Lyndon-Li Lyndon-Li added this to the v1.12 milestone Sep 4, 2023
@Lyndon-Li
Copy link
Contributor Author

The preliminary idea is to remove the code here for now.

@sseago Let me know if you have different ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CSI Related to Container Storage Interface support area/datamover target/1.11.2 target/1.12-rc.2
Projects
None yet
Development

No branches or pull requests

1 participant