Update restore controller logic for restore deletion #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
230905_restore
branch
from
9d11e35
to
3342eee
Compare
1. Skip deleting the restore files from storage if the backup/BSL is not found 2. Allow deleting the restore files from storage even though the BSL is readonly Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
230905_restore
branch
from
3342eee
to
e4c9594
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.12 #6761 +/- ##
=============================================
Coverage 60.38% 60.38%
=============================================
Files 242 242
Lines 25981 25981
=============================================
Hits 15689 15689
- Misses 9189 9190 +1
+ Partials 1103 1102 -1
|
Lyndon-Li
approved these changes
Sep 5, 2023
|
LGTM |
allenxu404
approved these changes
Sep 5, 2023
sseago
approved these changes
Sep 5, 2023
sseago
pushed a commit
to openshift/velero
that referenced
this pull request
May 23, 2024
1. Skip deleting the restore files from storage if the backup/BSL is not found 2. Allow deleting the restore files from storage even though the BSL is readonly Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.