[release-1.12]: CP issue #6807: Retry failed create when using generateName #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
approved these changes
Oct 11, 2023
sseago
force-pushed
the
retry-generateName1.12
branch
2 times, most recently
from
6626cd0
to
73608cc
Compare
shubham-pampattiwar
approved these changes
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.12 #6943 +/- ##
=============================================
Coverage 60.47% 60.47%
=============================================
Files 246 247 +1
Lines 26376 26398 +22
=============================================
+ Hits 15950 15965 +15
- Misses 9304 9312 +8
+ Partials 1122 1121 -1
|
When creating resources with generateName, apimachinery does not guarantee uniqueness when it appends the random suffix to the generateName stub, so if it fails with already exists error, we need to retry. Signed-off-by: Scott Seago <sseago@redhat.com>
sseago
force-pushed
the
retry-generateName1.12
branch
from
73608cc
to
457fcc6
Compare
Lyndon-Li
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating resources with generateName, apimachinery does not guarantee uniqueness when it appends the random suffix to the generateName stub, so if it fails with already exists error, we need to retry.
Does your change fix a particular issue?
Fixes #6807
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.