Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.120: CP Perf improvements for existing resource restore #6948

Merged
merged 1 commit into from Oct 13, 2023

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Oct 12, 2023

Use informer cache with dynamic client for Get calls on restore When enabled, also make the Get call before create.

Add server and install parameter to allow disabling this feature, but enable by default

CP from merged main commit

Does your change fix a particular issue?

Fixes #6845

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Use informer cache with dynamic client for Get calls on restore
When enabled, also make the Get call before create.

Add server and install parameter to allow disabling this feature,
but enable by default

Signed-off-by: Scott Seago <sseago@redhat.com>
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #6948 (a3cb39d) into release-1.12 (c1ace31) will increase coverage by 0.11%.
The diff coverage is 88.72%.

@@               Coverage Diff                @@
##           release-1.12    #6948      +/-   ##
================================================
+ Coverage         60.38%   60.50%   +0.11%     
================================================
  Files               246      246              
  Lines             26262    26376     +114     
================================================
+ Hits              15859    15958      +99     
- Misses             9287     9297      +10     
- Partials           1116     1121       +5     
Files Coverage Δ
pkg/controller/restore_controller.go 66.09% <100.00%> (+0.12%) ⬆️
pkg/install/deployment.go 88.79% <100.00%> (+0.33%) ⬆️
pkg/restore/request.go 100.00% <ø> (ø)
pkg/cmd/server/server.go 22.15% <66.66%> (+0.17%) ⬆️
pkg/client/dynamic.go 0.00% <0.00%> (ø)
pkg/install/resources.go 75.39% <0.00%> (-0.90%) ⬇️
pkg/restore/restore.go 65.93% <91.74%> (+1.54%) ⬆️

@Lyndon-Li Lyndon-Li merged commit d92a051 into vmware-tanzu:release-1.12 Oct 13, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants