Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HealthCheckNodePort deletion logic in Serivce restore #7026

Merged
merged 1 commit into from Oct 27, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Oct 26, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6376

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet changed the title Add HealthCheckNodePort deletion logic. Add HealthCheckNodePort deletion logic in Serivce restore Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7026 (a949180) into main (fd8350f) will decrease coverage by 0.02%.
Report is 24 commits behind head on main.
The diff coverage is 48.83%.

@@            Coverage Diff             @@
##             main    #7026      +/-   ##
==========================================
- Coverage   61.05%   61.03%   -0.02%     
==========================================
  Files         251      252       +1     
  Lines       26845    26898      +53     
==========================================
+ Hits        16389    16417      +28     
- Misses       9303     9319      +16     
- Partials     1153     1162       +9     
Files Coverage Δ
pkg/restore/service_action.go 58.44% <48.83%> (-1.92%) ⬇️

... and 15 files with indirect coverage changes

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet merged commit 9ff4b1e into vmware-tanzu:main Oct 27, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Velero needs to clear auto created HealthCheckNodePort during restore
3 participants