Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the credential file to avoid the change of secret content messing it up #7058

Merged
merged 1 commit into from Nov 8, 2023

Conversation

ywk253100
Copy link
Contributor

@ywk253100 ywk253100 commented Nov 6, 2023

Truncate the credential file to avoid the change of secret content messing it up

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #7058 (6438fc9) into release-1.12 (bb4f909) will not change coverage.
Report is 1 commits behind head on release-1.12.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release-1.12    #7058   +/-   ##
=============================================
  Coverage         60.58%   60.58%           
=============================================
  Files               247      247           
  Lines             26416    26416           
=============================================
  Hits              16004    16004           
  Misses             9289     9289           
  Partials           1123     1123           
Files Coverage Δ
internal/credentials/file_store.go 60.00% <100.00%> (ø)

@ywk253100 ywk253100 changed the title Remove the credential file first to avoid the change of secret content messing it up Truncate the credential file to avoid the change of secret content messing it up Nov 6, 2023
…ssing it up

Truncate the credential file to avoid the change of secret content messing it up

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@qiuming-best qiuming-best merged commit d139922 into vmware-tanzu:release-1.12 Nov 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants