Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter part2 #7151

Merged
merged 6 commits into from Nov 29, 2023
Merged

Linter part2 #7151

merged 6 commits into from Nov 29, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 28, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (b8604b6) 61.77% compared to head (f5c159c) 61.74%.

Files Patch % Lines
pkg/datamover/dataupload_delete_action.go 0.00% 7 Missing ⚠️
pkg/cmd/util/output/describe.go 33.33% 3 Missing and 1 partial ⚠️
pkg/controller/backup_deletion_controller.go 0.00% 4 Missing ⚠️
pkg/backup/backup.go 40.00% 1 Missing and 2 partials ⚠️
pkg/controller/pod_volume_restore_controller.go 0.00% 1 Missing ⚠️
pkg/podvolume/restorer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7151      +/-   ##
==========================================
- Coverage   61.77%   61.74%   -0.04%     
==========================================
  Files         259      259              
  Lines       27865    27883      +18     
==========================================
+ Hits        17214    17216       +2     
- Misses       9446     9459      +13     
- Partials     1205     1208       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the linter_part2 branch 2 times, most recently from d19cce7 to f7c108d Compare November 28, 2023 07:41
@blackpiglet blackpiglet force-pushed the linter_part2 branch 2 times, most recently from efbc178 to 353c0f1 Compare November 28, 2023 08:06
@blackpiglet blackpiglet marked this pull request as ready for review November 28, 2023 09:08
Xun Jiang added 6 commits November 29, 2023 11:13
Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
@Lyndon-Li Lyndon-Li merged commit 4d21e29 into vmware-tanzu:main Nov 29, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants