Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition matching in resource modifier when there are multiple rules #7715

Merged
merged 1 commit into from May 14, 2024

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Apr 22, 2024

Please add a summary of your change

Fix condition matching in resource modifier when there are multiple rules

Does your change fix a particular issue?

Fixes #7714

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.67%. Comparing base (3c37c84) to head (b0f96cd).
Report is 4 commits behind head on main.

Files Patch % Lines
internal/resourcemodifiers/resource_modifiers.go 77.27% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7715   +/-   ##
=======================================
  Coverage   58.66%   58.67%           
=======================================
  Files         344      344           
  Lines       28731    28737    +6     
=======================================
+ Hits        16854    16860    +6     
  Misses      10448    10448           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reasonerjt
Copy link
Contributor

@27149chen Could you rebase to fix the linter errors?

@anshulahuja98
Copy link
Collaborator

PR LGTM - @27149chen can you please consider adding a unit test for the scenario you described in the issue to ensure we do not regress this in future and the behaviour is captured in the UTs atleast.

@reasonerjt reasonerjt added this to the v1.14 milestone Apr 30, 2024
@anshulahuja98
Copy link
Collaborator

gentle ping @27149chen

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label May 11, 2024
@27149chen
Copy link
Contributor Author

gentle ping @27149chen

ut added, apologies for the delay

@27149chen
Copy link
Contributor Author

@27149chen Could you rebase to fix the linter errors?

done

@blackpiglet
Copy link
Contributor

@27149chen
Sorry for interruption again, the CI action failed due to go.mod file is out-of-date.

@27149chen
Copy link
Contributor Author

@27149chen Sorry for interruption again, the CI action failed due to go.mod file is out-of-date.

@blackpiglet , I have run go mod tidy, but with no help

…ent.

Fix condition matching in resource modifier when there are multiple rules

Signed-off-by: lou <alex1988@outlook.com>
@blackpiglet
Copy link
Contributor

@27149chen
I rebase and squash the commits. The go module issue is fixed.
Hope that's OK for you.

Please check out and sign off again to make the DCO check pass.

@27149chen
Copy link
Contributor Author

@27149chen I rebase and squash the commits. The go module issue is fixed. Hope that's OK for you.

Please check out and sign off again to make the DCO check pass.

@blackpiglet thanks, DCO looks right

@sseago sseago merged commit 6c2b66b into vmware-tanzu:main May 14, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Documentation has-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Modifier: Condition matching is incorrect when there are multiple rules
5 participants