Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptiveCrypto for iOS native code refactor #36

Closed
hawkinsji opened this issue Nov 1, 2023 · 0 comments · Fixed by #37
Closed

CaptiveCrypto for iOS native code refactor #36

hawkinsji opened this issue Nov 1, 2023 · 0 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request

Comments

@hawkinsji
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The native code in the CaptiveCrypto sample app for iOS is all in one big file.
https://github.com/vmware/captive-web-view/blob/main/forApple/CaptiveCrypto/CaptiveCrypto/StoredKey.swift

Describe the solution you'd like

The code should be in several smaller files, perhaps making use of a Swift enumeration as a namespace.

This type of solution was already implemented for #28 which was the same issue in the code for Android.

Describe alternatives you've considered

No response

Additional context

No response

@hawkinsji hawkinsji added the enhancement New feature or request label Nov 1, 2023
@hawkinsji hawkinsji changed the title CaptiveCrypto for Android native code refactor CaptiveCrypto for iOS native code refactor Nov 1, 2023
@hawkinsji hawkinsji self-assigned this Nov 1, 2023
@hawkinsji hawkinsji linked a pull request Nov 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant