Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Please replace #!/bin/bash with #!/bin/sh #207

Closed
yurivict opened this issue Jan 4, 2020 · 2 comments · Fixed by #231
Closed

Please replace #!/bin/bash with #!/bin/sh #207

yurivict opened this issue Jan 4, 2020 · 2 comments · Fixed by #231

Comments

@yurivict
Copy link
Contributor

yurivict commented Jan 4, 2020

/bin/bash only exists by default on Linux, on other systems it needs to be installed and it has different path. But your scripts work fine with Bourne shell which is available everywhere at /bin/sh.

@eschkufz
Copy link
Contributor

eschkufz commented Jan 4, 2020

I'll start going through these one at a time. We'll close out the easy stuff and then figure out why the regression tests are failing.

eschkufz added a commit that referenced this issue Jan 4, 2020
Signed-off-by: eric schkufza <eric.schkufza@gmail.com>
@eschkufz eschkufz mentioned this issue Jan 4, 2020
2 tasks
@eschkufz
Copy link
Contributor

eschkufz commented Jan 6, 2020

(This one's taking a bit longer than expected --- the scripts in the share/ directory are bash in name only, and mostly posix-compliant. The setup script needs some work.)

@eschkufz eschkufz mentioned this issue Jan 9, 2020
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants