Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Tree view is not considering the states when collapsed state #1400

Closed
girijaa opened this issue Aug 31, 2017 · 29 comments
Closed

Tree view is not considering the states when collapsed state #1400

girijaa opened this issue Aug 31, 2017 · 29 comments

Comments

@girijaa
Copy link

girijaa commented Aug 31, 2017

Select one ... (check one with "x")

[ X] bug
[ ] feature request
[ ] enhancement

Expected behavior

In collpased state, if i uncheck or check that state will be consider.

Actual behavior

In collpse mode, if we change the state that state is not considering , it holds the previous ste only(it means, in expand mode what we selected i.e)

Reproduction of behavior

  • Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

Environment details

  • Angular version: 2.0.X

  • Clarity version:

  • OS and version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

@adibwoy
Copy link
Contributor

adibwoy commented Aug 31, 2017

@girijaa: Could you please provide a plnkr to replicate this issue? Without a plnkr it is difficult for us to reproduce the issue and investigate it.

@adibwoy adibwoy added the status: needs info Need more information from the issue author. label Aug 31, 2017
@youdz
Copy link
Contributor

youdz commented Aug 31, 2017

Actually, I don't want us to lose time investigating a potential bug from a one-line description that I have a very hard time understanding.

So before we investigate, @girijaa, could you please post a plunker reproducing the issue you have? Thank you.

@girijaa
Copy link
Author

girijaa commented Aug 31, 2017 via email

@adibwoy
Copy link
Contributor

adibwoy commented Aug 31, 2017

@girijaa: This does look like a bug. We will take a look and get back to you.

@adibwoy adibwoy added type: bug ClarityNG and removed status: needs info Need more information from the issue author. labels Aug 31, 2017
@girijaa
Copy link
Author

girijaa commented Sep 4, 2017

Hi,
May i know, did you people resolve this issue.

@mathisscott
Copy link
Contributor

@girijaa
It's in our backlog but is not currently being worked. Thanks for checking in!

@yelhouti
Copy link

yelhouti commented Sep 22, 2017

I'm facing a variant of this bug two:
https://plnkr.co/edit/HsXrzOkJ49tIy9EEvKew?p=preview
when outer is expanded it works as expected
when it's not, checking inner (that is outside) doesn't change the checkbox of outer.
PS: the initial bug is much worse than this (ie: if outer is selected when collapsed, inner is not selected).

@kumar-tadepalli
Copy link

kumar-tadepalli commented Dec 14, 2017

When this will be fixed?
Is there any workaround for this?
Component should expose events/emit the events for checkbox changes and collapse/expand events with the object to handle it by ourselfs which is not the case.
Please prioritize this! It has been hanging in open state from more than 5 months :-(
We are blocked here. :(

@mathisscott
Copy link
Contributor

mathisscott commented Dec 14, 2017

@adityarb88 @youdz @jeeyun
Are there any details you can share on this item?

@kumar-tadepalli
Copy link

Any update on this?

@adibwoy
Copy link
Contributor

adibwoy commented Jan 2, 2018

@shravansofts: Apologies for the late reply. I was on vacation. We haven't gotten time to take a look at this yet because of other priorities. I will try and get an update on what can be done for this from the team this week.

jeeyun added a commit to jeeyun/clarity that referenced this issue Jan 11, 2018
…ding (vmware-archive#1400)

Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>
@kumar-tadepalli
Copy link

Any ETA on this fix?

@adibwoy
Copy link
Contributor

adibwoy commented Jan 18, 2018

Hi @shravansofts. No ETA yet. We will get to this when someone from the team is available to work on this. As of now everyone is tied up working on other components/issues.

Also, if you want to investigate this and submit a PR, we would be happy to review it and merge in the fix. Thanks!

@KANekT
Copy link

KANekT commented Jul 17, 2018

@Itay777 Until Clarity worked on this bug - I use
https://github.com/leovo2708/ngx-treeview/tree/master/src/lib

@Itay777
Copy link

Itay777 commented Jul 24, 2018

Hi @jeeyun,
any update on this bug fix progress?

@jeeyun
Copy link
Contributor

jeeyun commented Jul 24, 2018

Hi @Itay777, we want to provide solution for two use cases - 1. a simpler use case where all the tree nodes are already defined and populated in the DOM (which allows Clarity component to provide comprehensive state management out of the box) and 2. a more complex use case where we want to allow the component to fetch and destroy the children nodes on demand (e.g. when a user clicks to expand and collapse a node) which means that the component cannot know all the information about the states of the children ahead of time and the application-side would have to manage state. Thinking about both use cases requires a more thorough examination (and possible refactoring) of our API so it's taking a bit longer. I will provide another update here when we have a more concrete timeline for projected completion. Thank you for checking in and asking. Also, feel free to share your use case and what is the typical size and depth of the treeviews in your application. Knowing concrete example helps us to make sure we build something that's useful!

@Itay777
Copy link

Itay777 commented Jul 25, 2018

Hi @jeeyun here is an example of our usecase on stackblitz.

We are using the tree component to filter items by state from the data grid:

  • we are using 3 level depth tree.
  • we initialize the tree from json\ code.
  • by default all nodes are selected.
  • when any selection change happens, we are sending an ajax request to the server, with updated list of selected nodes.
  • when we want to select\ unselect a group of nodes, then we check \uncheck the parent node, and any child node gets selected\ unselected.
  • when we want to select one or more specific nodes, then we unselect all nodes by unchecking the root node, then select the required nodes.

Hope it is clear enough, please don't be afraid to ask if something is unclear.

@deniszholob
Copy link

deniszholob commented Aug 2, 2018

You mess with it long enough you get a nice light show...
*1 Clicking the same checkbox way to fast
*2 Some combination of expanding/collapsing with intermediate states (or maybe i clicked to fast and invoked it with *1)
2018-08-01_21-22-49

@Itay777
Copy link

Itay777 commented Oct 2, 2018

Hi @jeeyun,
any ETA?

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests