Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Password eye icon is aligned too far right in the login page #3084

Closed
dorthrithil opened this issue Jan 29, 2019 · 1 comment · Fixed by #3158
Closed

Password eye icon is aligned too far right in the login page #3084

dorthrithil opened this issue Jan 29, 2019 · 1 comment · Fixed by #3158
Assignees
@coryrylan
Labels
Dev priority: 1 low type: bug
Milestone
2.0

Comments

@dorthrithil
Copy link

Describe the bug

This is how the eye icon is aligned in standard password inputs:

screen shot 2019-01-29 at 10 57 43

This is how it looks in the login page:

screen shot 2019-01-29 at 10 58 56

How to reproduce

Compare https://clarity.design/documentation/login to https://clarity.design/documentation/password

Expected behavior

Alignment is consistent across different components.

Versions

App

  • Angular: 7
  • Node: 10.1.0
  • Clarity: 1.0.4

Device:

  • Browser Chrome
@coryrylan coryrylan self-assigned this Feb 22, 2019
@coryrylan coryrylan mentioned this issue Feb 22, 2019
Closed
coryrylan pushed a commit to coryrylan/clarity that referenced this issue Mar 3, 2019
[NG] fix input group styles/tests
96afe14 
closes vmware-archive#3084 closes vmware-archive#3083

Signed-off-by: Cory Rylan <crylan@vmware.com>
@coryrylan coryrylan mentioned this issue Mar 3, 2019
Merged
coryrylan pushed a commit to coryrylan/clarity that referenced this issue Mar 3, 2019
[NG] fix input group styles/tests
929accc 
closes vmware-archive#3084 closes vmware-archive#3083

Signed-off-by: Cory Rylan <crylan@vmware.com>
coryrylan pushed a commit to coryrylan/clarity that referenced this issue Mar 3, 2019
[NG] fix input group styles/tests
f2916bc 
closes vmware-archive#3084 closes vmware-archive#3083

Signed-off-by: Cory Rylan <crylan@vmware.com>
coryrylan added a commit that referenced this issue Mar 6, 2019
@coryrylan
[NG] fix input group styles/tests (#3158)
2717e5d 
closes #3084 closes #3083

Signed-off-by: Cory Rylan <crylan@vmware.com>
coryrylan pushed a commit that referenced this issue Mar 6, 2019
[NG] fix input group styles/tests
0f2d427 
closes #3084 closes #3083

Signed-off-by: Cory Rylan <crylan@vmware.com>
@coryrylan coryrylan modified the milestones: 1.1.1, 2.0 Mar 7, 2019
@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coryrylan coryrylan

Labels
Dev priority: 1 low type: bug
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[NG] fix input group styles/tests coryrylan/clarity
3 participants
@gnomeontherun @coryrylan @dorthrithil