This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
HSL / HSLA color #3286
Comments
mathisscott
pushed a commit
to mathisscott/clarity
that referenced
this issue
Aug 7, 2019
• because SASS has an hsl() function it jumps in and converts all our values to hex in the generated CSS • that makes this a minimal impact on our existing codebase • the value of this migration is so design can analyze how we are using hues • this will allow us to improve our color schemes by aligning hues and simplifying our color values • ideally, this will allow simplified color theming to grow out of changing one or two hue values in the SASS add'l notes • generated icons did not like being passed values from the hsl functions • this was because the SASS hsl function would return white and black instead of hex values like the generated icons wanted • additionally, the generated icons could not translate the values of our SASS variables via the hsl() output • the quick and dirty solution was to hard-code the values with hex codes for now b/c we are trying to get rid of generated icons altogether Tested in: ✔︎ Chrome ✔︎ Firefox Closes: vmware-archive#3286 Signed-off-by: Scott Mathis <smathis@vmware.com>
14 tasks
mathisscott
pushed a commit
to mathisscott/clarity
that referenced
this issue
Aug 9, 2019
• because SASS has an hsl() function it jumps in and converts all our values to hex in the generated CSS • that makes this a minimal impact on our existing codebase • the value of this migration is so design can analyze how we are using hues • this will allow us to improve our color schemes by aligning hues and simplifying our color values • ideally, this will allow simplified color theming to grow out of changing one or two hue values in the SASS add'l notes • generated icons did not like being passed values from the hsl functions • this was because the SASS hsl function would return white and black instead of hex values like the generated icons wanted • additionally, the generated icons could not translate the values of our SASS variables via the hsl() output • the quick and dirty solution was to hard-code the values with hex codes for now b/c we are trying to get rid of generated icons altogether Tested in: ✔︎ Chrome ✔︎ Firefox Closes: vmware-archive#3286 Signed-off-by: Scott Mathis <smathis@vmware.com>
mathisscott
pushed a commit
that referenced
this issue
Aug 9, 2019
• because SASS has an hsl() function it jumps in and converts all our values to hex in the generated CSS • that makes this a minimal impact on our existing codebase • the value of this migration is so design can analyze how we are using hues • this will allow us to improve our color schemes by aligning hues and simplifying our color values • ideally, this will allow simplified color theming to grow out of changing one or two hue values in the SASS add'l notes • generated icons did not like being passed values from the hsl functions • this was because the SASS hsl function would return white and black instead of hex values like the generated icons wanted • additionally, the generated icons could not translate the values of our SASS variables via the hsl() output • the quick and dirty solution was to hard-code the values with hex codes for now b/c we are trying to get rid of generated icons altogether Tested in: ✔︎ Chrome ✔︎ Firefox Closes: #3286 Signed-off-by: Scott Mathis <smathis@vmware.com>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Covert to a color system that has the advantages of being human readable, and being effectively editable by designers in CSS.
The text was updated successfully, but these errors were encountered: