Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Not overridable variable #3544

Closed
sebastien-p opened this issue Jul 2, 2019 · 2 comments · Fixed by #3701
Closed

Not overridable variable #3544

sebastien-p opened this issue Jul 2, 2019 · 2 comments · Fixed by #3701
Assignees
@mathisscott
Labels
Oops
Milestone
2.1.2

Comments

@sebastien-p
Copy link

Describe the bug

As you can see here, the $clr-table-fontsize variable is not declared as !default so there sadly is no way to override it properly. This is the only variable in this file not declared as !default, is it normal?

Expected behavior

The $clr-table-fontsize should be declared as !default.

Versions

App

  • Angular: 8
  • Node: 12
  • Clarity: 2.0.1
@mathisscott mathisscott added this to the 2.1 milestone Jul 2, 2019
@sebastien-p
Copy link
Author

Maybe this is not the only variable declared without !default.

@mathisscott mathisscott self-assigned this Aug 9, 2019
mathisscott pushed a commit to mathisscott/clarity that referenced this issue Aug 14, 2019
fix(table): table font-size not overrideable
32e10b2 
notes:
• just missing default
• i will backport to 1.x

Tested in:
✔︎ Chrome

Fixes: vmware-archive#3544

Signed-off-by: Scott Mathis <smathis@vmware.com>
@mathisscott mathisscott mentioned this issue Aug 14, 2019
Merged
14 tasks
mathisscott pushed a commit that referenced this issue Aug 14, 2019
@mathisscott
fix(table): table font-size not overrideable
b7bea0d 
notes:
• just missing default
• i will backport to 1.x

Tested in:
✔︎ Chrome

Fixes: #3544

Signed-off-by: Scott Mathis <smathis@vmware.com>
mathisscott pushed a commit that referenced this issue Aug 14, 2019
fix(table): table font-size not overrideable
6a298df 
notes:
• just missing default
• i will backport to 1.x

Tested in:
✔︎ Chrome

Fixes: #3544

Signed-off-by: Scott Mathis <smathis@vmware.com>
@mathisscott mathisscott modified the milestones: 2.2, 1.2.2, 2.1.2 Aug 14, 2019
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mathisscott mathisscott

Labels
Oops
Projects
None yet
Milestone
2.1.2
Development

Successfully merging a pull request may close this issue.

fix(table): table font-size not overrideable mathisscott/clarity
2 participants
@sebastien-p @mathisscott