Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Accordion styling issue: #3685

Closed
furti opened this issue Aug 9, 2019 · 2 comments · Fixed by #3695
Closed

Accordion styling issue: #3685

furti opened this issue Aug 9, 2019 · 2 comments · Fixed by #3695

Comments

@furti
Copy link

furti commented Aug 9, 2019

Round corners on last panel

When the last panel of a accordion is expanded, the bottom corners of the panel are still rounded. And it seems that there are two borders at the bottom of the panel.

I consider this as a minor inconsistency as the stackview does not have rounded corners and duplicated borders for the last panel.

Accordion

image

Stack View

image

How to reproduce

Go to https://clarity.design/documentation/accordion and open the last panel of the example accordion to see the rounded corners.

Go to https://clarity.design/documentation/stack-view and open the last panel of the example stack view to see no rounded corners.

Expected behavior

There should be no rounded corners and duplicated borders on the last panel of the accordion.

Versions

App

Clarity Documentation for v2.

Device:

  • Type: Notebook
  • OS: Windows 10
  • Browser chrome
  • Version 67
@furti
Copy link
Author

furti commented Aug 9, 2019

As a workaround I added this styles to my scss files.

.clr-accordion:not(.clr-stepper-forms) .clr-accordion-panel:last-child {
    .clr-accordion-panel-open {
        .clr-accordion-header {
            border-bottom-left-radius: 0;
            border-bottom-right-radius: 0;
            border-bottom: none;
        }
    }
}

royling pushed a commit to royling/clarity that referenced this issue Aug 13, 2019
royling pushed a commit to royling/clarity that referenced this issue Aug 14, 2019
Fixed vmware-archive#3685

Signed-off-by: Roy Ling <royling0024@gmail.com>
royling pushed a commit to royling/clarity that referenced this issue Aug 14, 2019
Fixed vmware-archive#3685

Signed-off-by: Roy Ling <royling0024@gmail.com>
royling added a commit to royling/clarity that referenced this issue Aug 14, 2019
Fixed vmware-archive#3685

Signed-off-by: Roy Ling <royling0024@gmail.com>
gnomeontherun pushed a commit that referenced this issue Aug 19, 2019
Fixed #3685

Signed-off-by: Roy Ling <royling0024@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants