This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(alert): fix alert-text width for IE11 #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes vmware-archive#4548. IE11 doesn't calculate the correct height of .alert-text. Signed-off-by: Matt Hippely <mhippely@vmware.com>
gnomeontherun
approved these changes
May 12, 2020
gnomeontherun
added
v1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #4548. IE11 doesn't calculate the correct height of .alert-text.
Signed-off-by: Matt Hippely mhippely@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
IE11 has an issue calculating the height of long multiline content for global alerts when flex-basis is set to auto.
Issue Number: #4548
.alert-textelements set a percentage for other device size screens. This PR updates the default to be 100%Does this PR introduce a breaking change?
Other information