This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(datagrid): colType and field are set before trying to configure f… #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilters Angular could assign colType and field in an random order, so we need to wait before we could start using them to assign the filter type for that reason we use ngOnChanges to be sure everything is set and then call setupDefaultFilter Backport from v3 to v4 (master) Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>
mathisscott
approved these changes
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting from master to v4