This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(a11y): removing restriction for banner/app alerts to be one line #5233
+1
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• removed height restrictions forcing banner alerts to be one line • removed truncation on banner alerts from CSS • it is recommended that apps NOT wrap the content inside a banner alert but sometimes that is not realistic • given the current implementation of banner alerts it is recommended that paging through multiple alerts uses either opacity or visibility instead of display: none CSS styles so that content jumping can be avoided. Signed-off-by: Scott Mathis <smathis@vmware.com>
Shijir
approved these changes
Oct 30, 2020
jeeyun
approved these changes
Oct 30, 2020
mathisscott
added
resolution: fixed
and removed
Dev
priority: 5 high
status: in progress
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• removed height restrictions forcing banner alerts to be one line
• removed truncation on banner alerts from CSS
• it is recommended that apps NOT wrap the content inside a banner alert but sometimes that is not realistic
• given the current implementation of banner alerts it is recommended that paging through multiple alerts uses either opacity or visibility instead of display: none CSS styles so that content jumping can be avoided <= @Shijir for app-alert pagination demo!!!
Signed-off-by: Scott Mathis smathis@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Banner alerts are forced to remain one-line tall and truncate any content overflow
Issue Number: In a11y backlog
What is the new behavior?
Banner alert content wraps.
Does this PR introduce a breaking change?
CC: @scroniser