This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix: assign correct described-by id to form input and control helpers #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdryanovski
commented
Feb 3, 2021
packages/angular/projects/clr-angular/src/forms/radio/radio-container.ts
Outdated
Show resolved
Hide resolved
bdryanovski
commented
Feb 3, 2021
packages/angular/projects/clr-angular/src/forms/radio/radio-container.ts
Outdated
Show resolved
Hide resolved
bdryanovski
commented
Feb 3, 2021
packages/angular/projects/clr-angular/src/forms/tests/container.spec.ts
Outdated
Show resolved
Hide resolved
bdryanovski
commented
Feb 3, 2021
bdryanovski
force-pushed
the
fix-aria-describe
branch
3 times, most recently
from
0c6f369
to
2400be4
Compare
14 tasks
bdryanovski
force-pushed
the
fix-aria-describe
branch
from
2400be4
to
3c2d699
Compare
bbogdanov
approved these changes
Mar 5, 2021
* provide another service for creating container/control ID * set correct role to elements * set describe by id and link it to control helper/error/success Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>
bdryanovski
force-pushed
the
fix-aria-describe
branch
from
18348db
to
1411777
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Fixes #5429
Fixes #4650