Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

chore: fix dark theme config in Angular dev app #5848

Merged
merged 1 commit into from Apr 15, 2021

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Apr 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Starting the dev app in dark mode (yarn serve:dark) fails with:

Error: ../icons/src/clr-icons.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleError: Module Error (from ./node_modules/@angular-devkit/build-angular/node_modules/postcss-loader/dist/cjs.js):
Loading PostCSS "" parser failed: The argument 'id' must be a non-empty string. Received ''

Issue Number: N/A

What is the new behavior?

Starting the dev app in dark mode works fine. Thanks, @bdryanovski for providing the solution!

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Stanimira Vlaeva <stanimira.vlaeva@gmail.com>
@sis0k0 sis0k0 requested a review from bdryanovski April 14, 2021 16:15
@sis0k0 sis0k0 merged commit 06bd66a into vmware-archive:next Apr 15, 2021
@sis0k0 sis0k0 deleted the fix-ng-app-dark-theme-config branch April 15, 2021 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants