This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(modal): making modal content items focusable #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• previously modal content could not be focused using the tab key • this included form fields and buttons in the content area of a modal • this fixes that issue by changing the modal content wrapper's tabindex to 0 • ...and setting delegatesFocus to true Signed-off-by: Scott Mathis <smathis@vmware.com>
mathisscott
requested review from
jeeyun and
gnomeontherun
and removed request for
gnomeontherun and
jeeyun
coryrylan
approved these changes
Apr 29, 2021
mathisscott
requested review from
gnomeontherun and
jeeyun
and removed request for
jeeyun and
gnomeontherun
hippee-lee
approved these changes
Apr 30, 2021
jeeyun
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• previously modal content could not be focused using the tab key
• this included form fields and buttons in the content area of a modal
• this fixes that issue by changing the modal content wrapper's tabindex to 0
• ...and setting delegatesFocus to true
Signed-off-by: Scott Mathis smathis@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Users can now tab down into the modal-content area.
What is the current behavior?
Right now, users can't tab down into the modal-content area's shadow DOM.
What is the new behavior?
Now they can.
Does this PR introduce a breaking change?