This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(tree-view): error EHCAIWC for lazy expandable nodes #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbogdanov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
9 tasks
Jinnie
approved these changes
May 17, 2021
jeeyun
approved these changes
May 17, 2021
Closes vmware-archive#5927 The main reason for EHCAIWC was that [in this function](https://github.com/vmware/clarity/blob/next/packages/angular/projects/clr-angular/src/data/tree-view/models/recursive-tree-node.model.ts#L46) the Promise or the Observable can be resolved too quickly and the `loading` property value can be changed before the next change detection cycle. I'm resolving the issue with a pattern we used for the [datagrid selection](https://github.com/vmware/clarity/blob/next/packages/angular/projects/clr-angular/src/data/datagrid/providers/selection.ts#L164) that in first case it was producing a EHCAIWC, then we did a fix and the fix was skipping a change detection cycle and we end up with out last solution that seems to be the best one so far. Signed-off-by: Bogdan Bogdanov <bbogdanov@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for EHCAIWC was that in this function the Promise or the Observable can be resolved too quickly and the
loadingproperty value can be changed before the next change detection cycle.I'm resolving the issue with a pattern we used for the datagrid selection that in first case it was producing a EHCAIWC, then we did a fix and the fix was skipping a change detection cycle and we end up with out last solution that seems to be the best one so far.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5927
What is the new behavior?
EHCAIWC is not produced anymore.
Does this PR introduce a breaking change?
Other information
A way to see the issue is not available anymore is:
devapptree-viewLazy recursive treeAsynchronous, loading exactly what's visibleexample