Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix(dropdown): fix the styles for icons with shape caret #5946

Merged
merged 1 commit into from May 14, 2021

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented May 13, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Icons (both clr-icon and cds-icon) with shape caret inside clr-dropdown buttons look different to icons with shape angle. They should look the same because caret is an alias to angle.

Issue Number: #5941

What is the new behavior?

The styles for both shapes are aligned.

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Stanimira Vlaeva <stanimira.vlaeva@gmail.com>
@sis0k0 sis0k0 requested a review from coryrylan May 13, 2021 16:06
@sis0k0 sis0k0 self-assigned this May 13, 2021
@sis0k0 sis0k0 merged commit e16ac2e into vmware-archive:next May 14, 2021
@sis0k0 sis0k0 deleted the fix-dropdown-icon branch May 14, 2021 11:47
@sis0k0 sis0k0 mentioned this pull request May 14, 2021
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants