This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat(button): core flat-inline action #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbogdanov
force-pushed
the
add/flat-inline
branch
from
bf3d884
to
116b375
Compare
coryrylan
approved these changes
May 19, 2021
mathisscott
approved these changes
May 19, 2021
bbogdanov
force-pushed
the
add/flat-inline
branch
from
116b375
to
5507d52
Compare
coryrylan
approved these changes
May 19, 2021
mathisscott
suggested changes
May 19, 2021
| --background: #{$cds-alias-object-opacity-0}; | ||
| --border-color: #{$cds-alias-object-opacity-0}; | ||
| --color: #{$cds-alias-status-info}; | ||
| --box-shadow-color: #{$cds-alias-object-opacity-0}; | ||
| } | ||
|
|
||
| :host([action='flat-inline']) { | ||
| --height: auto; | ||
| --padding: 0; |
There was a problem hiding this comment.
I thought we only wanted to remove padding from the left and the right. Why would we remove all padding here?
There was a problem hiding this comment.
The buttons in the card footer are adding additional bottom space and it is not possible to remove that space without an additional token. Like we do with --card-remove-margin.
--height: auto will help us accomplish to remove that space and have an even padding that won't make the footer bigger than what's needed.
Also I and Cory discuss that and we thought having a --height: auto will bring more inline feeling.
Closes vmware-archive#5775 We also needed a way to have a button with no padding on the right and left this one is giving us just what we need. Signed-off-by: Bogdan Bogdanov <bbogdanov@vmware.com>
mathisscott
approved these changes
May 19, 2021
bbogdanov
force-pushed
the
add/flat-inline
branch
from
5507d52
to
476e636
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5775
We also needed a way to have a button with no padding on the right and left this one is giving us just what we need.
Signed-off-by: Bogdan Bogdanov bbogdanov@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5775
What is the new behavior?
Having a flat button with no padding on left and right
Does this PR introduce a breaking change?
Other information