This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Address several tree-view element issues #6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippee-lee
commented
Jan 13, 2022
hippee-lee
commented
Jan 13, 2022
hippee-lee
commented
Jan 13, 2022
| @@ -379,6 +383,78 @@ export const interactive = () => { | |||
| `; | |||
| }; | |||
|
|
|||
| export function conditionalItems() { | |||
| @customElement('demo-conditional-tree') | |||
There was a problem hiding this comment.
Complex tree demo for conditional DOM.
hippee-lee
commented
Jan 13, 2022
hippee-lee
force-pushed
the
topic/tree-view-cleanup
branch
from
962da56
to
68714f8
Compare
mathisscott
approved these changes
Jan 21, 2022
coryrylan
reviewed
Jan 21, 2022
This change handles several isses that were encountered when triaging usage of the cds-tree-item with angular's *ngIf structural directive. 1. This change adds registration of for the new cds-button-expand element used in the temlate. 2. This change adds a code comment to further describe both the automatic and manual use cases for `expandable` 3. THis change adds a dynamic demo that demonstrates how to use the expandable with complex trees 4. This change adds a test in the tree-item spec to make sure the button is in the DOM when a cds-tree-item element is `expandable`. Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee
force-pushed
the
topic/tree-view-cleanup
branch
from
68714f8
to
1b95e57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change handles several isses that were encountered when triaging
usage of the cds-tree-item with angular's *ngIf structural directive.
element used in the temlate.
automatic and manual use cases for
expandableexpandable with complex trees
is in the DOM when a cds-tree-item element is
expandable.Signed-off-by: Matt Hippely mhippely@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
As described above this adds a demo for conditional DOM on cds-tree-item elements. (think *ngIf for Angular apps). It also adds some context for the expandable property as it has an automatic and a manual use case. Finally, It adds a test into the spec to make sure the button is in the DOM when an element is 'expandable'.
What is the current behavior?
Missing register for cds-button-expand, no dev notes for the manual use case of the expandable property and there is no test to make sure the expand button is in the DOM when a cds-tree-item is expandable.
Issue Number: N/A
What is the new behavior?
Added register code, added dev context to the expandable property, added a spec for the expandable property. Finally, it adds a demo for conditional cds-tree-items in a complex tree.
Does this PR introduce a breaking change?
Other information