This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
[NG] Bug Fix for Datepicker in Reactive Forms #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adibwoy
force-pushed
the
topic/aditya/datepicker-reactive-form-fixes
branch
from
8ee1e54
to
6ef816c
Compare
youdz
suggested changes
Mar 21, 2018
| if (date) { | ||
| this._dateNavigationService.selectedDay = | ||
| new DayModel(date.getFullYear(), date.getMonth(), date.getDate()); | ||
| this.writeDateStrToInputField(this._ngControl.value); |
There was a problem hiding this comment.
That's a lot of code duplication with processUserDateObject(). It's actually the same method, but processUserDateObject() starts by converting the Date object to a string, then does exactly the same as this.
Please rewrite these two methods so that they share the common code.
youdz
approved these changes
Mar 21, 2018
Fixes: vmware-archive#2093 Signed-off-by: Aditya Bhandari <adityab@vmware.com>
adibwoy
force-pushed
the
topic/aditya/datepicker-reactive-form-fixes
branch
from
6d1bf78
to
8faa67f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2093
The initial value set by the user in Reactive Forms wasn't being processed by the Date Picker. Fixes that issue. For more details see #2093
Tested on Chrome
Signed-off-by: Aditya Bhandari adityab@vmware.com