This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
[UI] Dropdown Nested Menu Arrow Alignment Fix #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youdz
approved these changes
May 8, 2018
Shijir
approved these changes
May 8, 2018
hippee-lee
suggested changes
May 8, 2018
| @@ -130,7 +130,7 @@ | |||
| } | |||
|
|
|||
| &.expandable { | |||
| $clr-dropdown-caret-xOffset: 0.333rem; | |||
| $clr-dropdown-caret-margin-top: 0.375rem; | |||
There was a problem hiding this comment.
Can we move this to ./_variables.dropdown.scss ?
There was a problem hiding this comment.
I don't think we can because its a local variable. It changes in different breakpoints. I would have to create multiple variables if we want to do that. For now, I think this is fine. The whole dropdown css needs a refactor and we can get this fixed that time. Does that sound okay?
hippee-lee
approved these changes
May 8, 2018
Fixes: vmware-archive#2219 Signed-off-by: Aditya Bhandari <adityab@vmware.com>
adibwoy
force-pushed
the
topic/aditya/dropdown-fix
branch
from
d6e946b
to
36a7835
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2219
Before:
After:
Signed-off-by: Aditya Bhandari adityab@vmware.com