This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Schematic fix for webcomponents script ordering and monorepo support #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we put the webcomponents polyfill first closes vmware-archive#2410 Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
This enables installing Clarity into a monorepo and cleans up some of the logic closes vmware-archive#2406 Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
adibwoy
approved these changes
Jul 4, 2018
Shijir
approved these changes
Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for a mono-repo with schematics by declaring the
--projectflag. Originally it only would install into the main app module, now it can optionally target a different project.This fixes a bug where webcomponents polyfill was after the icons script.
Closes #2406 #2410