This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
[NG] Page size change was not triggering a state change (#1752) #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve#1752) StateDebouncer calls added to the size setter. Signed-off-by: Ivan Donchev <idonchev@vmware.com>
mathisscott
approved these changes
Nov 14, 2018
hippee-lee
approved these changes
Nov 14, 2018
|
@Jinnie |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During 0.9 -> 0.10 refactoring, the refresh has no longer been managed locally in the datagrid component, but delegated to the state provider service. Thus, we're no longer listening to page.change events directly.
StateDebouncer calls added to the size setter, similar to the current setter.
Tests are checking initial size change (from not set), then transition from one size to another, finally a size reset.