This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat: add no-clr-alert rule to detect the usage of Clarity Angular alerts #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippee-lee
approved these changes
Nov 9, 2020
| return { | ||
| 'HTMLElement[tagName="clr-alert"]'(node: HTMLElement): void { | ||
| context.report({ | ||
| node: node as any, |
There was a problem hiding this comment.
Are there issues that prevent this from being typed as HTMLElement?
There was a problem hiding this comment.
Unfortunately, the HTMLElement type is incompatible with the TSESTree type as defined by the @typescript/eslint library.
| const classes = classNode?.attributeValue?.value?.split(' ') || []; | ||
| if (classes.includes('alert')) { | ||
| context.report({ | ||
| node: node as any, |
There was a problem hiding this comment.
Same questionas line #30.
| @@ -1,24 +1,14 @@ | |||
| import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils'; | |||
| import { JSDOM } from 'jsdom'; | |||
| import { SourceLocation } from '@typescript-eslint/eslint-plugin'; | |||
| import { getDecoratorPropertyValue } from '../utils'; | |||
| import { calculateLocation, getDecoratorTemplate } from '../utils'; | |||
| output?: string; | ||
| } | ||
|
|
||
| interface Location { |
There was a problem hiding this comment.
Is it worth using this type in the calculateLocation utility function as something named
ElementLocation || TemplateLocation
?
There was a problem hiding this comment.
After looking into this for a while, I've found an appropriate type exported by @typescript-eslint and used it instead.
…erts Signed-off-by: Stanimira Vlaeva <svlaeva@vmware.com>
sis0k0
force-pushed
the
eslint-rule/alert
branch
from
651982d
to
03a7dee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The usage of Clarity Angular alerts is not being detected.
What is the new behavior?
The ESLint plugin (
@clr/eslint-clarity-migration) now has a rule detecting the usage of Clarity Angular alerts.Does this PR introduce a breaking change?
Other information