Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Bring plugin volume discovery back #1050

Closed
msterin opened this issue Mar 20, 2017 · 1 comment
Closed

Bring plugin volume discovery back #1050

msterin opened this issue Mar 20, 2017 · 1 comment
Labels
component/guest-plugin kind/bug P0
Milestone
0.13

Comments

@msterin
Copy link
Contributor

msterin commented Mar 20, 2017 •
edited by pdhamdhere

Discovery was turned off in #1047 - see details there.

We need to bring it back for crash recovery scenario of managed plugin.

[ ] update to latest Docker client SDK - @pshahzeb
[ ] use client API with timeouts, if we do not get reply within it (say 2 secs) , consider we are in start up mode and skip volume discovery - @pshahzeb
[ ] fix an issue with using DriverName to match volumes. Driver name in managed plugin could be whatever, so we'd better use PropagateMount location (i.e. /mnt/vmdk)
[ ] bring recovery test back refcnt_test.sh:test_crash_recovery, and use "docker-runc kill" there

// @pdhamdhere
@msterin msterin mentioned this issue Mar 20, 2017
Merged
@pdhamdhere pdhamdhere added this to the 0.13 milestone Mar 20, 2017
@msterin
Copy link
Contributor Author

msterin commented Mar 25, 2017

Note: Per moby/moby#31903 Docker engine API is fully functional only after the initialization is complete. Restore is in the middle of the initialization.. That's why we need to cut short all attempts to discover volumes if Docker engine does not reply in time

pshahzeb pushed a commit that referenced this issue Mar 27, 2017
Enabling timeout baesd usage of docker client API during startup
8282bb9 
1. Using timout based context while using docker client apis on plugin side to
   popluate the existing volume data

2. upgrading the docker client api version to 1.25

3. Removing environment variable to enable the volume discovery

Fixes #1050
pshahzeb pushed a commit that referenced this issue Mar 28, 2017
Enabling timeout baesd usage of docker client API during startup
011eb71 
1. Using timout based context while using docker client apis on plugin side to
   popluate the existing volume data

2. upgrading the docker client api version to 1.25

3. Removing environment variable to enable the volume discovery

Fixes #1050
@pshahzeb pshahzeb mentioned this issue Mar 28, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component/guest-plugin kind/bug P0
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
4 participants
@msterin @lipingxue @pdhamdhere @pshahzeb